kbendick commented on a change in pull request #1145:
URL: https://github.com/apache/iceberg/pull/1145#discussion_r460354928
##########
File path: core/src/main/java/org/apache/iceberg/BaseFile.java
##########
@@ -360,7 +360,7 @@ public ByteBuffer keyMetadata() {
if (list != null) {
List<E> copy = Lists.newArrayListWithExpectedSize(list.size());
copy.addAll(list);
- return Collections.unmodifiableList(copy);
Review comment:
No problem @openinx. There's essentially an issue with kryo's
`JaveSerializer` when used with flink. See here:
https://issues.apache.org/jira/browse/FLINK-6025 and here for more info:
https://ci.apache.org/projects/flink/flink-docs-stable/dev/custom_serializers.html#issue-with-using-kryos-javaserializer
If there's anyway I could be of assistance with this issue or any other work
for someone hopeful to start contributing to the project in a meaningful way,
I'd be very happy to. I'm personally evaluating iceberg for usage between flink
and spark as there are many flink users that I help oversee and we also have
need to integrate that work with spark.
I'd be happy to attempt a PR for a custom serializer, or would be happy to
work on anything that anybody feels would be good for a hopeful new committer /
contributor. Including tests, automation set up, flink support, etc.
Sorry if there's a better place to find this information; I am just getting
my hands dirty in contributing to an apache OSS project (though I have forked
some and then made changes and used those forks in production). I've also
browsed the issues etc, but I'm not quite sure how to go about being allowed to
get assigned one. My apologies if this is covered elsewhere; I'm used to being
able to browse the JIRA for apache projects (though I much prefer github).
cc @JingsongLi for potential guidance if you have a minute :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
