pvary commented on a change in pull request #1240:
URL: https://github.com/apache/iceberg/pull/1240#discussion_r460738276
##########
File path: hive/src/test/java/org/apache/iceberg/hive/HiveTableBaseTest.java
##########
@@ -66,6 +66,7 @@ public void dropTestTable() throws Exception {
tableLocation.getFileSystem(hiveConf).delete(tableLocation, true);
catalog.dropTable(TABLE_IDENTIFIER, false /* metadata only, location was
already deleted */);
}
+
Review comment:
Done
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -376,6 +376,28 @@ public TableOperations newTableOps(TableIdentifier
tableIdentifier) {
@Override
protected String defaultWarehouseLocation(TableIdentifier tableIdentifier) {
+ // This is a little edgy since we basically duplicate the HMS location
generation logic.
+ // Sadly I do not see a good way around this if we want to keep the order
of events, like:
+ // - Create meta files
+ // - Create the metadata in HMS, and thous commit the changes
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
