chenjunjiedada commented on a change in pull request #1239:
URL: https://github.com/apache/iceberg/pull/1239#discussion_r461419709
##########
File path: data/src/test/java/org/apache/iceberg/data/TestLocalScan.java
##########
@@ -174,6 +174,64 @@ private void overwriteExistingData() throws IOException {
.commit();
}
+ private void appendData() throws IOException {
Review comment:
Agree with you. The test data starts to become a bit hard to use if we
add more tests in future. I could try to clean this up, let me create an issue
in case we forget it.
##########
File path: data/src/test/java/org/apache/iceberg/data/TestLocalScan.java
##########
@@ -174,6 +174,64 @@ private void overwriteExistingData() throws IOException {
.commit();
}
+ private void appendData() throws IOException {
Review comment:
Agree with you. The test data starts to become a bit hard to use if we
add more tests in future. I could try to clean this up, let me create an [issue
](https://github.com/apache/iceberg/issues/1262)in case we forget it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
