massdosage commented on a change in pull request #1267:
URL: https://github.com/apache/iceberg/pull/1267#discussion_r462922676



##########
File path: build.gradle
##########
@@ -404,6 +408,29 @@ project(':iceberg-mr') {
       exclude group: 'org.apache.calcite.avatica'
     }
   }
+
+  shadowJar {
+    configurations = [project.configurations.compile]
+
+    zip64 true
+
+    // include the LICENSE and NOTICE files for the shaded Jar
+    from(projectDir) {
+      include 'LICENSE'
+      include 'NOTICE'
+    }
+
+    dependencies {
+      include(dependency('com.github.ben-manes.caffeine:caffeine:'))

Review comment:
       Yeah, as I said in the comment, I've just done this to see what the bare 
minimum needed to get it working on a cluster is. Once we have it actually 
working properly in Hive I can fix this up. I can try not specifying any 
dependencies and inherit all the compile time ones and relocate the problematic 
ones but my concern is that we're going to then end up having a huge number of 
clashes with other jars on Hive's classpath which is why I wanted to narrow 
this down to as few as possible. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to