sdd commented on code in PR #476:
URL: https://github.com/apache/iceberg-rust/pull/476#discussion_r1697459277
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -504,8 +504,15 @@ impl Catalog for RestCatalog {
.query::<LoadTableResponse, ErrorResponse, OK>(request)
.await?;
+ let config = resp
+ .config
+ .unwrap_or_default()
+ .into_iter()
+ .chain(self.user_config.props.clone().into_iter())
Review Comment:
But if it was that way around, you could not use the local user_config to
override a property that came from the REST service? I think we would want the
ability to do that. I think it makes more sense the way around that I have it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
