rdblue commented on a change in pull request #1213:
URL: https://github.com/apache/iceberg/pull/1213#discussion_r463346744
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Writer.java
##########
@@ -209,9 +212,15 @@ public String toString() {
return String.format("IcebergWrite(table=%s, format=%s)", table, format);
}
- private static class TaskCommit extends TaskResult implements
WriterCommitMessage {
- TaskCommit(TaskResult toCopy) {
- super(toCopy.files());
+ private static class TaskCommit implements WriterCommitMessage {
+ private final List<DataFile> taskFiles;
Review comment:
This should be an Array, like it was when this class was based on
`TaskResult`. Arrays are easier to handle when working with Serializable
classes because we don't have to worry about bugs caused by List
implementations (like the recent Kryo bug with unmodifiable lists).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
