rdblue commented on a change in pull request #1254:
URL: https://github.com/apache/iceberg/pull/1254#discussion_r463355014
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java
##########
@@ -85,6 +87,10 @@
this.rowGroups = reader.getRowGroups();
this.shouldSkip = new boolean[rowGroups.size()];
+ // Fetch all row groups starting positions to compute the row offsets of
the filtered row groups
+ Map<Long, Long> offsetToStartPos = generateOffsetToStartPos();
Review comment:
It just occurred to me (after merging this) that we may want to make
this lazy, like we do in Avro. That way if the row positions are never used, we
don't incur the cost of reading the footer another time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
