nastra commented on code in PR #10788:
URL: https://github.com/apache/iceberg/pull/10788#discussion_r1701765159
##########
baseline.gradle:
##########
@@ -86,11 +86,17 @@ subprojects {
'-Xep:CollectionUndefinedEquality:ERROR',
// specific to Palantir - Uses name `log` but we use name `LOG`
'-Xep:ConsistentLoggerName:OFF',
+ // TODO this is a recently added check. Figure out whether we adjust
the code or suppress for good
Review Comment:
I believe we should probably address all of these and then configure them to
`ERROR`.
Do you have a rough idea of how big the diff would be when addressing all of
the new error prone checks? I think if it's not too much then we can include it
in this PR.
Alternatively, we can open up separate issues and mark them as `good first
issue` to give other people a chance to contribute here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
