sl255051 commented on code in PR #10678:
URL: https://github.com/apache/iceberg/pull/10678#discussion_r1702976107
##########
core/src/test/java/org/apache/iceberg/TestPartitionSpecInfo.java:
##########
@@ -95,6 +96,30 @@ public void testSpecInfoPartitionedTable() {
.doesNotContainKey(Integer.MAX_VALUE);
}
+ @TestTemplate
+ public void testSpecInfoPartitionedTableCaseInsensitive() {
+ PartitionSpec spec =
+
PartitionSpec.builderFor(schema).caseSensitive(false).identity("DATA").build();
+ TestTables.TestTable table = TestTables.create(tableDir, "test", schema,
spec, formatVersion);
+
+ assertThat(table.spec()).isEqualTo(spec);
+
assertThat(table.spec().lastAssignedFieldId()).isEqualTo(spec.lastAssignedFieldId());
+ assertThat(table.specs())
+ .containsExactly(entry(spec.specId(), spec))
+ .doesNotContainKey(Integer.MAX_VALUE);
Review Comment:
Are you asking about the specific assert below? Actually, it doesn't
matter. All I did was take the test above, `testSpecInfoPartitionedTable` on
line 88, and make a case-insensitive version of the test. To understand the
purpose of the assert you'll have to ask the person who wrote
`testSpecInfoPartitionedTable`.
```
assertThat(table.specs())
.containsExactly(entry(spec.specId(), spec))
.doesNotContainKey(Integer.MAX_VALUE);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
