RussellSpitzer commented on code in PR #10861:
URL: https://github.com/apache/iceberg/pull/10861#discussion_r1703471612
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1015,6 +1015,11 @@ public Builder upgradeFormatVersion(int
newFormatVersion) {
"Cannot downgrade v%s table to v%s",
formatVersion,
newFormatVersion);
+ Preconditions.checkArgument(
+ newFormatVersion <= formatVersion + 1,
+ "Cannot skip format version(s) to upgrade v%s table to v%s",
+ formatVersion,
+ newFormatVersion);
Review Comment:
Ok looking through the rest of this update I think it probably shouldn't be
disallowed to skip versions, we should just be internally doing the stepwise
upgrade.
Because of that I think we need to remove all the gates on skipping versions
but also all of the added tests should not assume that the "version skip" is
just a single version, and instead just test skipping to latest.
So basically my thoughts for testing strategy is
Test
```
N => N+ 1
And
N => Max_Supported Version
```
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
