HeartSaVioR opened a new pull request #1280: URL: https://github.com/apache/iceberg/pull/1280
This patch fixes #1279 Kyro is not aware of Guava collection classes and trying to deal with the interface level which has no idea whether the implementation is immutable. I see we already fixed some of them, but during experimenting I found the another case, `BasedCombinedScanTask`. This patch changes BasedCombinedScanTask to retain the instance of Java's ArrayList, and adds relevant unit tests. There're some refactoring as well to deduplicate the code: * I found the implementation of `copyList` are scattered, hence created a new util class and moved it. * Comparing BaseCombinedScanTask needs compare of DataFile, which we already have the method for this, but in other test suite. I created a new helper class to move out comparison methods so that they can be co-used. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
