nastra commented on code in PR #10886:
URL: https://github.com/apache/iceberg/pull/10886#discussion_r1705585282
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -414,6 +414,11 @@
<property name="format" value="@Test\(.*expected.*\)"/>
<property name="message" value="Prefer using
Assertions.assertThatThrownBy(...).isInstanceOf(...) instead."/>
</module>
+ <module name="RegexpSinglelineJava">
+ <property name="format" value="^\s*assert\s+"/>
Review Comment:
I don't think we want to match code that doesn't compile or isn't properly
formatted. `fooassert´ isn't a valid statement and `assert(true)` would be
flagged as not properly formatted code by spotless, thus resulting in `assert
(true)`.
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -414,6 +414,11 @@
<property name="format" value="@Test\(.*expected.*\)"/>
<property name="message" value="Prefer using
Assertions.assertThatThrownBy(...).isInstanceOf(...) instead."/>
</module>
+ <module name="RegexpSinglelineJava">
+ <property name="format" value="^\s*assert\s+"/>
Review Comment:
I don't think we want to match code that doesn't compile or isn't properly
formatted. `fooassert` isn't a valid statement and `assert(true)` would be
flagged as not properly formatted code by spotless, thus resulting in `assert
(true)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
