rdsr commented on a change in pull request #1243:
URL: https://github.com/apache/iceberg/pull/1243#discussion_r463854512
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -66,7 +73,12 @@ public HiveAuthorizationProvider getAuthorizationProvider()
throws HiveException
@Override
public void configureInputJobProperties(TableDesc tableDesc, Map<String,
String> map) {
+ Properties props = tableDesc.getProperties();
+ Table table = Catalogs.loadTable(conf, props);
+ map.put(InputFormatConfig.TABLE_IDENTIFIER, props.getProperty(NAME));
+ map.put(InputFormatConfig.TABLE_LOCATION, table.location());
+ map.put(InputFormatConfig.TABLE_SCHEMA,
SchemaParser.toJson(table.schema()));
Review comment:
Depends upon where we set the catalog loader class. If we set it in
HiveConf, then it will always be available by default in configuration. If we
want to expose catalog loader class as a table property, e.g to load different
tables differently, then we can forward it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
