nastra commented on code in PR #10899: URL: https://github.com/apache/iceberg/pull/10899#discussion_r1709513215
########## core/src/main/java/org/apache/iceberg/view/BaseViewOperations.java: ########## @@ -104,7 +104,7 @@ public ViewMetadata refresh() { @Override public void commit(ViewMetadata base, ViewMetadata metadata) { // if the metadata is already out of date, reject it - if (base != current()) { + if (!current().equals(base)) { Review Comment: yes, in this case this warning should be ignored -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org