nastra commented on code in PR #10735:
URL: https://github.com/apache/iceberg/pull/10735#discussion_r1711079021
##########
core/src/main/java/org/apache/iceberg/BaseEntriesTable.java:
##########
@@ -283,19 +276,28 @@ static class ManifestReadTask extends BaseFileScanTask
implements DataTask {
private final ManifestFile manifest;
private final Map<Integer, PartitionSpec> specsById;
+ ManifestReadTask(Table table, ManifestFile manifest, Schema projection,
Expression filter) {
Review Comment:
should this be private maybe? Since it isn't used anywhere outside this class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
