RussellSpitzer commented on pull request #1287: URL: https://github.com/apache/iceberg/pull/1287#issuecomment-668163296
I wasn't really happy about doing the instance checking in Java (if dummy then cast), it makes me long for Scala :P I do think this is probably a minimal set of changes to get this in without breaking too much open On Mon, Aug 3, 2020 at 12:59 PM Ryan Blue <[email protected]> wrote: > Looks mostly good to me! > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg/pull/1287#issuecomment-668161352>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AADE2YN4YJZSKNOSMAPSBU3R633JDANCNFSM4PTQKJVQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
