kevinjqliu commented on issue #1051: URL: https://github.com/apache/iceberg-python/issues/1051#issuecomment-2287527950
> I think this change will result in make test being run twice in both make test-coverage, and in make test for all python versions. I'm wondering if there's a better way to solve this. [`python-ci.yml` ](https://github.com/apache/iceberg-python/blob/main/.github/workflows/python-ci.yml#L52-L53) runs `make test-coverage` [`python-integration.yml`](https://github.com/apache/iceberg-python/blob/main/.github/workflows/python-integration.yml#L42-L43) runs `make test-integration` Both run on each pull request. I think the subtle difference is not having the docker container up while running unit tests. > This way, we could generate the coverage reports for the unit tests first without the docker set up, set up the docker containers and then run the rest of the test suite +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
