chenjunjiedada commented on a change in pull request #1273:
URL: https://github.com/apache/iceberg/pull/1273#discussion_r464756257
##########
File path: data/src/test/java/org/apache/iceberg/data/TestLocalScan.java
##########
@@ -103,132 +103,100 @@ public TestLocalScan(String format) {
private String sharedTableLocation = null;
private Table sharedTable = null;
- private List<Record> file1Records = null;
- private List<Record> file2Records = null;
- private List<Record> file3Records = null;
- private List<Record> file1FirstSnapshotRecords = null;
- private List<Record> file2FirstSnapshotRecords = null;
- private List<Record> file3FirstSnapshotRecords = null;
- private List<Record> file1SecondSnapshotRecords = null;
- private List<Record> file2SecondSnapshotRecords = null;
- private List<Record> file3SecondSnapshotRecords = null;
+ private final Record genericRecord = GenericRecord.create(SCHEMA);
+
+ private final List<Record> file1FirstRecords = Lists.newArrayList(
Review comment:
Good idea. Applied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
