rdblue commented on a change in pull request #1288:
URL: https://github.com/apache/iceberg/pull/1288#discussion_r465221224
##########
File path: core/src/main/java/org/apache/iceberg/BaseFileScanTask.java
##########
@@ -31,14 +31,17 @@
class BaseFileScanTask implements FileScanTask {
private final DataFile file;
+ private final DeleteFile[] deletes;
private final String schemaString;
private final String specString;
private final ResidualEvaluator residuals;
private transient PartitionSpec spec = null;
- BaseFileScanTask(DataFile file, String schemaString, String specString,
ResidualEvaluator residuals) {
+ BaseFileScanTask(DataFile file, DeleteFile[] deletes, String schemaString,
String specString,
Review comment:
This implementation and constructor are internal and package-private.
The public API is the `FileScanTask` interface. I went ahead and updated all of
the places where we use this, so we don't need to have an overloaded
constructor. I think it is better to do it this way so that we ensure that the
parameter is always explicit and we aren't accidentally ignoring delete files
anywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
