amogh-jahagirdar commented on code in PR #10991:
URL: https://github.com/apache/iceberg/pull/10991#discussion_r1727917346
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java:
##########
@@ -217,6 +219,10 @@ public <T> Boolean lt(BoundReference<T> ref, Literal<T>
lit) {
return ROWS_CANNOT_MATCH;
}
+ if (fieldPromotedToString(ref, colStats)) {
Review Comment:
the method name `fieldPromotedToString` is not great since technically it's
not 100% that it really was promoted, we're using properties of the bounds to
just assume that a field was promoted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
