openinx opened a new issue #1302:
URL: https://github.com/apache/iceberg/issues/1302
I found that we did not put uuid type in `org.apache.iceberg.data.DataTest`,
and after added it in the `SUPPORTED_PRIMITIVES` (using the following patch),
it would break many unit tests.
```patch
diff --git a/data/src/test/java/org/apache/iceberg/data/DataTest.java
b/data/src/test/java/org/apache/iceberg/data/DataTest.java
index 5566a753..03f848a9 100644
--- a/data/src/test/java/org/apache/iceberg/data/DataTest.java
+++ b/data/src/test/java/org/apache/iceberg/data/DataTest.java
@@ -56,7 +56,8 @@ public abstract class DataTest {
required(114, "dec_9_0", Types.DecimalType.of(9, 0)),
required(115, "dec_11_2", Types.DecimalType.of(11, 2)),
required(116, "dec_38_10", Types.DecimalType.of(38, 10)), // maximum
precision
- required(117, "time", Types.TimeType.get())
+ required(117, "time", Types.TimeType.get()),
+ required(118, "uuid", Types.UUIDType.get())
);
@Rule
```
The broken unit tests:
We should add the uuid type in the tests and fix those broken cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
