kevinjqliu commented on code in PR #1141:
URL: https://github.com/apache/iceberg-python/pull/1141#discussion_r1759615542
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1251,10 +1253,17 @@ def _task_to_record_batches(
arrow_table = arrow_table.filter(pyarrow_filter)
if len(arrow_table) == 0:
continue
- batch = arrow_table.to_batches()[0]
- yield _to_requested_schema(
- projected_schema, file_project_schema, batch,
downcast_ns_timestamp_to_us=True, use_large_types=use_large_types
- )
+ output_batches = arrow_table.to_batches()
+ else:
+ output_batches = iter([batch])
Review Comment:
ah, didnt see that.
Do you mind adding a comment here to mention the possible `batch` mutation?
I feel like this might be an easy footgun later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
