hsiang-c commented on code in PR #5544:
URL: https://github.com/apache/iceberg/pull/5544#discussion_r1766090302
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -110,6 +115,15 @@ public void initialize(String inputName, Map<String,
String> properties) {
? new HadoopFileIO(conf)
: CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
+ if (catalogProperties.containsKey(CatalogProperties.ENCRYPTION_KMS_IMPL)) {
+ this.keyManagementClient = EncryptionUtil.createKmsClient(properties);
+ this.writerKekTimeout =
Review Comment:
- Wanna keep this PR active
- (nit) Maybe it make sense to add unit to the variable name, i.e.
`writerKekTimeoutMs`? For example, in `LockManagers`, we have
```java
this.heartbeatIntervalMs =
PropertyUtil.propertyAsLong(
properties,
CatalogProperties.LOCK_HEARTBEAT_INTERVAL_MS,
CatalogProperties.LOCK_HEARTBEAT_INTERVAL_MS_DEFAULT);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
