rdblue opened a new pull request #1317: URL: https://github.com/apache/iceberg/pull/1317
Utilities that compare partitions need to also track the partition spec that a partition tuple belongs to because the same set of partition values can be valid for multiple specs, but identify different partitions. Many classes track the partitions of data and delete files, and the easiest way to update those utilities is to pass the spec ID along with the `DataFile` instance. Otherwise, getting the correct spec ID would require updating several public APIs to add a spec ID argument. This PR adds spec ID to `DataFile` and `DeleteFile`, and adds it to metadata that is inherited from `ManifestFile`, where the spec ID of a manifest is tracked. This also cleans up unnecessary factory methods in `DataFile` that were used only in tests and were missing spec ID. Now, all data file creation uses the builder. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
