rdblue commented on a change in pull request #1264:
URL: https://github.com/apache/iceberg/pull/1264#discussion_r468261726
##########
File path: spark/src/main/java/org/apache/iceberg/actions/BaseAction.java
##########
@@ -41,4 +50,66 @@ protected String metadataTableName(MetadataTableType type) {
return tableName + "." + type;
}
}
+
+ /**
+ * Returns all the path locations of all Manifest Lists for a given table
+ * @param table the table
+ * @return the paths of the Manifest Lists
+ */
+ protected List<String> getManifestListPaths(Table table) {
+ List<String> manifestLists = Lists.newArrayList();
+ for (Snapshot snapshot : table.snapshots()) {
+ String manifestListLocation = snapshot.manifestListLocation();
+ if (manifestListLocation != null) {
+ manifestLists.add(manifestListLocation);
+ }
+ }
+ return manifestLists;
+ }
+
+ /**
+ * Returns all Metadata file paths which may not be in the current metadata.
Specifically
+ * this includes "version-hint" files as well as entries in
metadata.previousFiles.
+ * @param ops TableOperations for the table we will be getting paths from
+ * @return a list of paths to metadata files
+ */
+ protected List<String> getOtherMetadataFilePaths(TableOperations ops) {
Review comment:
Same here. Since we aren't making these common utility methods, we
should keep them private so we aren't committing to support them later on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
