JingsongLi commented on a change in pull request #1316:
URL: https://github.com/apache/iceberg/pull/1316#discussion_r468437233
##########
File path: core/src/main/java/org/apache/iceberg/MetadataColumns.java
##########
@@ -31,11 +31,20 @@
private MetadataColumns() {
}
+ // IDs Integer.MAX_VALUE - (1-100) are used for metadata columns
public static final NestedField FILE_PATH = NestedField.required(
Integer.MAX_VALUE - 1, "_file", Types.StringType.get(), "Path of the
file in which a row is stored");
public static final NestedField ROW_POSITION = NestedField.required(
Integer.MAX_VALUE - 2, "_pos", Types.LongType.get(), "Ordinal position
of a row in the source data file");
+ // IDs Integer.MAX_VALUE - (101-200) are used for reserved columns
+ public static final NestedField DELETE_FILE_PATH = NestedField.required(
Review comment:
I think they are different:
- reserved columns are just for position delete files.
- metadata columns are for all files. Actually, Position delete files also
have these metadata columns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
