arkadius commented on code in PR #11244:
URL: https://github.com/apache/iceberg/pull/11244#discussion_r1795763231
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/TestFlinkTableSinkExtended.java:
##########
@@ -165,18 +210,25 @@ public void testWriteParallelism() {
"INSERT INTO %s /*+ OPTIONS('write-parallelism'='1') */ SELECT *
FROM %s",
TABLE, SOURCE_TABLE);
ModifyOperation operation = (ModifyOperation)
planner.getParser().parse(insertSQL).get(0);
- Transformation<?> dummySink =
planner.translate(Collections.singletonList(operation)).get(0);
- Transformation<?> committer = dummySink.getInputs().get(0);
- Transformation<?> writer = committer.getInputs().get(0);
-
- assertThat(writer.getParallelism()).as("Should have the expected 1
parallelism.").isEqualTo(1);
- writer
- .getInputs()
- .forEach(
- input ->
- assertThat(input.getParallelism())
- .as("Should have the expected parallelism.")
- .isEqualTo(isStreamingJob ? 2 : 4));
+ Transformation<?> sink =
planner.translate(Collections.singletonList(operation)).get(0);
Review Comment:
I don't think that it is possible as we don't have builders here. Instead,
we have already built a chain of operators. This test works on the table
connectors level - builders are hidden behind the table connector API as an
implementation detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
