bryanck commented on code in PR #9641:
URL: https://github.com/apache/iceberg/pull/9641#discussion_r1799677923
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java:
##########
@@ -52,20 +51,22 @@ public IcebergWriter(Table table, String tableName,
IcebergSinkConfig config) {
private void initNewWriter() {
this.writer = Utilities.createTableWriter(table, tableName, config);
- // FIXME: update this when the record converter is added
- // this.recordConverter = new RecordConverter(table, config);
+ this.recordConverter = new RecordConverter(table, config);
Review Comment:
The main concern from the community in adding CDC support is that relying on
equality deletes can result in performance problems, unless you compact your
data regularly. Once those concerns are addressed we can add it, and take into
account the issue you're encountering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
