rdblue commented on a change in pull request #1318:
URL: https://github.com/apache/iceberg/pull/1318#discussion_r469448459



##########
File path: api/src/main/java/org/apache/iceberg/ContentFile.java
##########
@@ -102,6 +102,18 @@
    */
   List<Long> splitOffsets();
 
+  /**
+   * Returns the set of field IDs used for equality comparison, in equality 
delete files.
+   * <p>
+   * An equality delete file may contain additional data fields that are not 
used by equality
+   * comparison. The subset of columns in a delete file to be used in equality 
comparison are
+   * tracked by ID. Extra columns can be used to reconstruct changes and 
metrics from extra

Review comment:
       I think it was intended. The second half of the sentence is "Metrics 
from extra columns are used during job planning". We might be able to rephrase 
it to avoid the double "extra columns", but I wanted to be clear that the 
metrics are coming from the extra columns.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to