amogh-jahagirdar commented on code in PR #11180:
URL: https://github.com/apache/iceberg/pull/11180#discussion_r1803561481
##########
core/src/main/java/org/apache/iceberg/BaseFile.java:
##########
@@ -434,6 +434,11 @@ public StructLike partition() {
return partitionData;
}
+ public void setPartitionData(PartitionData partitionData) {
Review Comment:
Ah BaseFile isn't public itself but still, think we should just avoid the
extra method since it's possible to do everything via the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
