jackye1995 commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1810979748
##########
aws/src/integration/java/org/apache/iceberg/aws/AwsIntegTestUtil.java:
##########
@@ -127,6 +129,21 @@ public static void cleanS3Bucket(S3Client s3, String
bucketName, String prefix)
}
}
+ /**
+ * Method used to clean up a S3 directory bucket which doesn't care about
versions
+ *
+ * @param s3FileIO an instance of s3FileIO to be used to list/delete objects
+ * @param bucketName name of the bucket
+ * @param prefix the path prefix we want to remove
+ */
+ public static void cleanS3DirectoryBucket(S3FileIO s3FileIO, String prefix,
String bucketName) {
Review Comment:
yes, that's why I think it is important to not use those calls in test
cleanup logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
