edgarRd opened a new pull request #1339: URL: https://github.com/apache/iceberg/pull/1339
Unlike Parquet metrics, ORC was not using `MetricsConfig` to let the user configure which metrics to collect or truncate string column metrics. This PR fixes #1268 by adding `MetricsConfig` support in ORC metrics. I've also added unit tests to `TestMetrics`, which runs for both Parquet and ORC, to check the different `MetricsModes` and the truncation of string and binary (not supported in ORC) columns. PTAL @aokolnychyi @rdsr @shardulm94 Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
