rdsr commented on a change in pull request #1243:
URL: https://github.com/apache/iceberg/pull/1243#discussion_r470367437
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergInputFormat.java
##########
@@ -45,9 +47,9 @@
import static org.apache.iceberg.types.Types.NestedField.required;
@RunWith(StandaloneHiveRunner.class)
-public class TestHiveIcebergInputFormat {
+public abstract class TestHiveIcebergInputFormat {
Review comment:
it is kinda weird that we are calling this class
`TestHiveIcebergInputFormat` instead of say `TestHiveStorageHandler` or
something similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
