JingsongLi commented on a change in pull request #1293:
URL: https://github.com/apache/iceberg/pull/1293#discussion_r470424985
##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java
##########
@@ -98,4 +102,24 @@ public static TableSchema toSchema(RowType rowType) {
}
return builder.build();
}
+
+ /**
+ * Prune columns from a {@link Schema} using a projected fields.
+ * TODO Why Spark care about filters?
Review comment:
The columns which has been involved in push-down filter must be in the
projection column list. Because just like spark:
`Spark doesn't support residuals per task, so return all filters to get
Spark to handle record-level filtering`.
Flink source also doesn't support residuals per task, left these filtering
to Flink planner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
