RussellSpitzer commented on pull request #1336: URL: https://github.com/apache/iceberg/pull/1336#issuecomment-674164207
Ah that makes sense to me, I thought these identifiers were internal only, but it makes much more sense to me now! On Fri, Aug 14, 2020 at 11:45 AM Ryan Blue <[email protected]> wrote: > Thanks for reviewing, @RussellSpitzer <https://github.com/RussellSpitzer>! > I'll fix those issues. > > The short names are more obvious because they don't contain a hard-coded > string that users need to know about. Consider the schema from the > description, locations list<struct<lat: double, long: double>>. How does > someone know to add element to reference locations.element.lat? I think > it's more natural to allow referencing that field as locations.lat, as > long as it doesn't conflict with other names. > > We've also already supported these names, so I think we should continue to > support them. But adding the full names removes ambiguity introduced by the > short names. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg/pull/1336#issuecomment-674163196>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AADE2YO6LJS2MP3DFDJC6LTSAVS3DANCNFSM4P6UNE3A> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
