RussellSpitzer commented on a change in pull request #1342:
URL: https://github.com/apache/iceberg/pull/1342#discussion_r470788727
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopTables.java
##########
@@ -68,27 +71,26 @@ public HadoopTables(Configuration conf) {
*/
@Override
public Table load(String location) {
- TableOperations ops = newTableOps(location);
Review comment:
An alternative to this implementation that I considered was modifying
findTable itself. The problem with this is that to do that implementation we
need to extract the loadMetadataTable from below. I think this is a cleaner
solution but we could do something where we make a StaticTables.java which
findTables uses to either return a basetable or metadataTable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
