kbendick commented on a change in pull request #1334:
URL: https://github.com/apache/iceberg/pull/1334#discussion_r470918955
##########
File path: pig/src/main/java/org/apache/iceberg/pig/IcebergPigInputFormat.java
##########
@@ -243,6 +243,7 @@ private boolean advance() throws IOException {
return true;
}
+ @SuppressWarnings("ByteBufferBackingArray")
Review comment:
Ok. Thanks for the insight. This was one admittedly that I suppressed
but wasn't sure about later on. I'm in agreement though, due to the same
arguments I've given elsewhere. I know much less about Pig, but I think it's
better to be safe than sorry here if we don't know about the exact behavior of
the input source, not or in the future.
Should I update it in this PR or another PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
