kbendick commented on pull request #1334: URL: https://github.com/apache/iceberg/pull/1334#issuecomment-675896595
> @kbendick, can you revert the last few changes? I think this was fairly close to ready, but not any more. > > For the ORC path, we do need to use the backing byte array if there is one, to avoid unnecessary copying. Copying is a really expensive operation and we want to avoid it unless the bytes are off heap. I think the only thing that needed to be fixed was to avoid modifying the original buffer by using `duplicate` before reading off-heap bytes, instead of modifying the buffer and then restoring its state. > > For Pig, I think you just need to call `duplicate` before reading the bytes as well. I rolled back to @edgarRd's review and then I applied all of your suggestions (I believe). Everything should be as requested now. Thanks for taking a look! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
