omalley commented on a change in pull request #1326:
URL: https://github.com/apache/iceberg/pull/1326#discussion_r473313825



##########
File path: 
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java
##########
@@ -51,6 +58,17 @@
 
     forwardConfigSettings(job);
 
+    //Convert Hive filter to Iceberg filter
+    String hiveFilter = job.get(TableScanDesc.FILTER_EXPR_CONF_STR);

Review comment:
       The most common places to put it are:
   * getSplits - to filter the splits aggressively
   * getRecordReader - to filter the records while reading
   
   The information is being set by HiveInputFormat.pushFilters, but looking 
through the various paths to get there I think you need to stick to those.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to