rdblue commented on a change in pull request #1344:
URL: https://github.com/apache/iceberg/pull/1344#discussion_r473351737
##########
File path: spark/src/main/java/org/apache/iceberg/actions/BaseAction.java
##########
@@ -86,17 +90,22 @@ protected String metadataTableName(MetadataTableType type) {
}
protected Dataset<Row> buildValidDataFileDF(SparkSession spark) {
- String allDataFilesMetadataTable =
metadataTableName(MetadataTableType.ALL_DATA_FILES);
+ return buildValidDataFileDF(spark, table().toString());
+ }
+
+ protected Dataset<Row> buildValidDataFileDF(SparkSession spark, String
tableName) {
+ String allDataFilesMetadataTable = metadataTableName(tableName,
MetadataTableType.ALL_DATA_FILES);
return
spark.read().format("iceberg").load(allDataFilesMetadataTable).select("file_path");
}
- protected Dataset<Row> buildManifestFileDF(SparkSession spark) {
- String allManifestsMetadataTable =
metadataTableName(MetadataTableType.ALL_MANIFESTS);
+ protected Dataset<Row> buildManifestFileDF(SparkSession spark, String
tableName) {
+ String allManifestsMetadataTable = metadataTableName(tableName,
MetadataTableType.ALL_MANIFESTS);
return
spark.read().format("iceberg").load(allManifestsMetadataTable).selectExpr("path
as file_path");
}
- protected Dataset<Row> buildManifestListDF(SparkSession spark, Table table) {
- List<String> manifestLists = getManifestListPaths(table);
+ protected Dataset<Row> buildManifestListDF(SparkSession spark, String
tableName, TableOperations ops) {
+ Table snapshot = new BaseTable(ops, tableName);
Review comment:
I think it is misleading to use `snapshot` here, since that term usually
refers to a version of a table, not a table itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
