amogh-jahagirdar commented on code in PR #11586:
URL: https://github.com/apache/iceberg/pull/11586#discussion_r1848789823
##########
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##########
@@ -158,6 +164,9 @@ static Snapshot fromJson(JsonNode node) {
manifestList);
} else {
+ LOG.warn(
+ "Support for embedded manifests are deprecated since Iceberg 1.8.0,
will be removed in either 1.9.0 or 2.0.0");
Review Comment:
Hm, I'm a bit concerned about deprecating the ability to *read* embedded
manifests.
I certainly think it makes sense to stop writing them for v1, but there may
still be some v1 tables out there that we don't want to break reads on those in
a later Iceberg version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
