nastra commented on code in PR #11616:
URL: https://github.com/apache/iceberg/pull/11616#discussion_r1851864597
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction3.java:
##########
@@ -61,6 +61,8 @@ public void testSparkCatalogTable() throws Exception {
assertThat(StreamSupport.stream(results.orphanFileLocations().spliterator(),
false))
.as("trash file should be removed")
.anyMatch(file -> file.contains("file:" + location + trashFile));
+
+ cat.purgeTable(id);
Review Comment:
the initial approach to avoid this issue in the first place was to have a
randomized part in the table name via
`ThreadLocalRandom.current().nextInt(1000)`. Maybe we should update this to
have a random UUID instead?
My concern with calling `cat.purgeTable(id)` is that this code isn't
necessarily reached when the test fails in between for other reasons
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
