dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1853134029
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##########
@@ -386,6 +386,12 @@ public void
testHiveTableAndIcebergTableWithSameName(TableType tableType)
assertThat(catalog.tableExists(TABLE_IDENTIFIER)).isTrue();
HIVE_METASTORE_EXTENSION.metastoreClient().dropTable(DB_NAME,
hiveTableName);
+
Review Comment:
Yeah I I agree with you on different test for new feature. But in this
particular case, it was already part of dropTable tests in
https://github.com/apache/iceberg/blob/a52afdc484f9e63477b96d0182586692daac8eab/core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java#L838-L845
and `catalog.tableExists` was tested pretty extensively in all other existing
unit tests as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
