openinx commented on a change in pull request #1185:
URL: https://github.com/apache/iceberg/pull/1185#discussion_r473771348
##########
File path: core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java
##########
@@ -27,7 +28,7 @@
import org.apache.iceberg.encryption.EncryptedOutputFile;
import org.apache.iceberg.encryption.EncryptionManager;
-public class OutputFileFactory {
+public class OutputFileFactory implements Serializable {
Review comment:
Because the `IcebergStreamWriter` will need the
`RowDataTaskWriterFactory` to create `TaskWriter`, it could pass it to
`TaskWriterFactory` when constructing, that means all members inside
`RowDataTaskWriterFactory` should be serializable (include itself),
unfortunately `OutputFileFactory` is one of its member.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
