Fokko commented on PR #712:
URL: https://github.com/apache/iceberg-rust/pull/712#issuecomment-2493686502

   Hey @gruuya Thanks for creating this PR. Unfortunately, Iceberg does not 
support relative paths. There is a long open issue 
https://github.com/apache/iceberg/issues/1617 but it is pretty complex to 
implement. As an example, merge-on-read [uses absolute 
paths](https://github.com/apache/iceberg/blob/main/format/spec.md#position-delete-files)
 to know which files to apply the deletes to. Adding support for relative paths 
makes this very brittle since the path might not be matched correctly, 
resulting in data correctness issues.
   
   Instead, for testing, I would suggest symlinking similar to what I did in 
https://github.com/pola-rs/polars/pull/10375/ or running a MinIO S3 container, 
similar to the integration tests of iceberg-rust itself: 
https://github.com/apache/iceberg-rust/blob/main/crates/catalog/rest/testdata/rest_catalog/docker-compose.yaml


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to