jzhuge commented on pull request #1357: URL: https://github.com/apache/iceberg/pull/1357#issuecomment-677760886
The dependency on bundled-guava is declared using the following syntax (suggested by Shadow Plugin doc): compile project(path: ':iceberg-bundled-guava', configuration: 'shadow') Maybe Idea does not interpret it properly? On Thu, Aug 20, 2020 at 1:06 AM openinx <[email protected]> wrote: > There's a GuavaClasses inside the empty jar. Without that class, then > bundled-guava won't reference any classes from guava ? finally, the > relocate won't have effect in this module. But I don't understand why could > we build this project in terminal. > > public class GuavaClasses { > > /* * Referencing Guava classes here includes them in the minimized and relocated Guava jar */ > static { > VisibleForTesting.class.getName(); > Joiner.class.getName(); > MoreObjects.class.getName(); > Objects.class.getName(); > Preconditions.class.getName(); > Splitter.class.getName(); > Throwables.class.getName(); > BiMap.class.getName(); > FluentIterable.class.getName(); > ImmutableBiMap.class.getName(); > ImmutableList.class.getName(); > ImmutableMap.class.getName(); > ImmutableSet.class.getName(); > Iterables.class.getName(); > Iterators.class.getName(); > ListMultimap.class.getName(); > Lists.class.getName(); > MapMaker.class.getName(); > Maps.class.getName(); > Multimap.class.getName(); > Multimaps.class.getName(); > Ordering.class.getName(); > Sets.class.getName(); > Streams.class.getName(); > Hasher.class.getName(); > HashFunction.class.getName(); > Hashing.class.getName(); > Files.class.getName(); > Bytes.class.getName(); > MoreExecutors.class.getName(); > ThreadFactoryBuilder.class.getName(); > Iterables.class.getName(); > } > > } > > [image: image] > <https://user-images.githubusercontent.com/5028729/90732685-0adc4600-e2fe-11ea-9009-875ef9a40a8d.png> > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg/pull/1357#issuecomment-677445102>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAOL5JFXRDLHZQ2QNMN2JULSBTKRNANCNFSM4QEBJXYQ> > . > -- John Zhuge ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
