RussellSpitzer commented on a change in pull request #1350:
URL: https://github.com/apache/iceberg/pull/1350#discussion_r474298501
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -409,11 +409,9 @@
<module name="JavadocMethod"> <!-- Java Style Guide: Where Javadoc is
used -->
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
- <property name="minLineCount" value="99999999"/>
<property name="allowedAnnotations" value="Override, Test"/>
- <property name="allowThrowsTagsForSubclasses" value="true"/>
+ <property name="validateThrows" value="false"/>
Review comment:
It's a bit of a complicated story
https://github.com/checkstyle/checkstyle/issues/7329
Long story short, the checks were basically broken before they were removed
and won't work. We actually don't need to set "validateThrows" to false either
since it is false by default. I just wanted to make sure we were aware that we
weren't validating any throw related tags.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
