kevinjqliu commented on code in PR #1386:
URL: https://github.com/apache/iceberg-python/pull/1386#discussion_r1861373849
##########
.github/workflows/python-release.yml:
##########
@@ -29,12 +29,30 @@ on:
jobs:
+ validate_version:
+ name: Validate version input
+ runs-on: ubuntu-latest
+ steps:
+ - name: Echo version input
+ run: |
+ echo "Version input is: ${{ github.event.inputs.version }}"
+
+ - name: Validate version input
+ if: ${{ github.event.inputs.version != 'main' &&
!contains(github.event.inputs.version, 'rc') }}
Review Comment:
had to do this since we run on different os environments with different
shells
##########
.github/workflows/python-release.yml:
##########
@@ -29,12 +29,30 @@ on:
jobs:
+ validate_version:
+ name: Validate version input
+ runs-on: ubuntu-latest
+ steps:
+ - name: Echo version input
+ run: |
+ echo "Version input is: ${{ github.event.inputs.version }}"
+
+ - name: Validate version input
+ if: ${{ github.event.inputs.version != 'main' &&
!contains(github.event.inputs.version, 'rc') }}
Review Comment:
had to do this since we run on different os environments with different
default shells
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
