RussellSpitzer edited a comment on pull request #1362: URL: https://github.com/apache/iceberg/pull/1362#issuecomment-678323110
Another idea is that we could just move all the deletes to the executors ... this would remove the need to configure something and all driver side work entirely. The only downsides I see to that are * we have to make a Serializable Consumer class for deletes (not a big deal) * we have to redo all the tests that use "Collection::add" to use an accumulator ... this should work * All logging about delete failures would be in executor logs so harder to actually see On Thu, Aug 20, 2020 at 6:58 PM Ryan Blue <[email protected]> wrote: > That sounds good to me! > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg/pull/1362#issuecomment-677963366>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AADE2YKLRGNKVC2V7HZ7TQLSBW2B3ANCNFSM4QGVJG7Q> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
