shangxinli commented on issue #193: URL: https://github.com/apache/iceberg/issues/193#issuecomment-678591337
I have the code working and I can see many pages filtered out now. I am going to add unit tests and create PR. I have one question for you. Does it make sense to change idToAlias(...) to findField(...).name() in the line https://github.com/apache/iceberg/blob/master/parquet/src/main/java/org/apache/iceberg/parquet/ParquetFilters.java#L120? Do you think it will work for nested fields? The reason for that is the variable 'aliasToId' in Schema class could be null. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
